Bump gradle version #518
Closed
Bump gradle version #518
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D28763472 |
Summary: Pull Request resolved: facebook#518 This diff updates the minimum gradle plugin version for building the Hermes OSS release in order to avoid problems in older versions of the Android NDK. Specifically, there was a bug (android/ndk#1166) in the Android NDK that caused the exception handling functions in `libc++` to be incorrectly exported. Depending on link order, this can lead to `libhermes.so` not statically linking in `_Unwind_resume`, and expecting it instead to be resolved dynamically to the version in `libc++`. However, if we're linking against an RN version that was built against the new version of the NDK, those symbols may not be exported, and end up unresolved (which crashes the app). To allow Hermes to be built with newer versions of the NDK, we need to bump up the gradle plugin version to 4.1. RN already uses 4.1. Bumping the gradle version seems to break the intl tests unless we add `useLibrary 'android.test.base'` to the gradle file, so do that. (we're technically supposed to have that anyway) Differential Revision: D28763472 fbshipit-source-id: 5706ee86d824339c6a3f0171992fe7ffe96cd188
|
This pull request was exported from Phabricator. Differential Revision: D28763472 |
neildhar
force-pushed
the
export-D28763472
branch
from
ff53fe9 to
9143549
Compare
|
This pull request has been merged in f61a798. |
Huxpro
pushed a commit
that referenced
this pull request
Jul 12, 2021
Summary: Pull Request resolved: #518 This diff updates the minimum gradle plugin version for building the Hermes OSS release in order to avoid problems in older versions of the Android NDK. Specifically, there was a bug (android/ndk#1166) in the Android NDK that caused the exception handling functions in `libc++` to be incorrectly exported. Depending on link order, this can lead to `libhermes.so` not statically linking in `_Unwind_resume`, and expecting it instead to be resolved dynamically to the version in `libc++`. However, if we're linking against an RN version that was built against the new version of the NDK, those symbols may not be exported, and end up unresolved (which crashes the app). To allow Hermes to be built with newer versions of the NDK, we need to bump up the gradle plugin version to 4.1. RN already uses 4.1. Bumping the gradle version seems to break the intl tests unless we add `useLibrary 'android.test.base'` to the gradle file, so do that. (we're technically supposed to have that anyway) Reviewed By: mhorowitz Differential Revision: D28763472 fbshipit-source-id: 00ffcfa94ee83a9dee0ac894e20e83867200865b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff updates the minimum gradle plugin version for building the
Hermes OSS release in order to avoid problems in older versions of
the Android NDK.
Specifically, there was a bug
(android/ndk#1166) in the Android NDK that
caused the exception handling functions in
libc++to be incorrectlyexported. Depending on link order, this can lead to
libhermes.sonot statically linking in
_Unwind_resume, and expecting it insteadto be resolved dynamically to the version in
libc++. However, ifwe're linking against an RN version that was built against the new
version of the NDK, those symbols may not be exported, and end up
unresolved (which crashes the app).
To allow Hermes to be built with newer versions of the NDK, we need
to bump up the gradle plugin version to 4.1. RN already uses 4.1.
Differential Revision: D28763472